Discussion:
nbcompat fix for newer Linux
Jonathan Perkin
2014-06-24 09:55:30 UTC
Permalink
bootstrap currently fails on Ubuntu with:

gcc -O2 -Wno-error -I/usr/include -Wno-error -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-uninitialized -Wreturn-type -Wcast-qual -Wpointer-arith -Wwrite-strings -Wswitch -Wshadow -Werror -D_LARGEFILE_SOURCE -D_LARGE_FILES -D_FILE_OFFSET_BITS=64 -DDEF_UMASK=022 -I/home/jperkin/git/pkgsrc/bootstrap/work/wrk/pkgtools/pkg_install/work/bzip2 -I/home/jperkin/git/pkgsrc/bootstrap/work/wrk/pkgtools/pkg_install/work/libarchive/libarchive -I/home/jperkin/git/pkgsrc/bootstrap/work/wrk/pkgtools/pkg_install/work/libfetch -DHAVE_NBCOMPAT_H=1 -I/home/jperkin/git/pkgsrc/bootstrap/work/wrk/pkgtools/pkg_install/work/libnbcompat -I/usr/include -I. -D_LARGEFILE_SOURCE -D_LARGE_FILES -D_FILE_OFFSET_BITS=64 -DINET6 -DWITH_SSL -DFTP_COMBINE_CWDS -c common.c
In file included from /home/jperkin/git/pkgsrc/bootstrap/work/wrk/pkgtools/pkg_install/work/libnbcompat/nbcompat/util.h:39:0,
from /home/jperkin/git/pkgsrc/bootstrap/work/wrk/pkgtools/pkg_install/work/libnbcompat/nbcompat.h:67,
from common.c:37:
/usr/include/libutil.h:33:2: error: #warning "Deprecated header, use <bsd/libutil.h> or libbsd-overlay.pc instead." [-Werror=cpp]
cc1: all warnings being treated as errors
*** Error code 1

The attached diff fixes it but we're way too far into the freeze for
it to go in, so I will hold off until next week. Until then, please
review for any platforms where this might potentially cause problems.

Thanks,
--
Jonathan Perkin - Joyent, Inc. - www.joyent.com
Joerg Sonnenberger
2014-06-24 11:33:09 UTC
Permalink
Post by Jonathan Perkin
The attached diff fixes it but we're way too far into the freeze for
it to go in, so I will hold off until next week. Until then, please
review for any platforms where this might potentially cause problems.
LGTM, even for commit during freeze.

Joerg

Loading...